Make record canonical constructors that can be compact compact#111
Merged
LexManos merged 3 commits intoMinecraftForge:masterfrom Feb 28, 2022
Merged
Make record canonical constructors that can be compact compact#111LexManos merged 3 commits intoMinecraftForge:masterfrom
LexManos merged 3 commits intoMinecraftForge:masterfrom
Conversation
variable can be moved back to where it was and compact constructor's can't use the throws clause anyway
Contributor
Author
|
The 2nd commit doesn't change the decompilation output but I did notice I left the decompiled jar in the folders when doing the diff originally so I updated it anyway. Here's the ForgeFlower patch after unindenting the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.18.2-rc1 diff
Couldn't move it to where the hide synthetic record methods is called since at that point the constructor parameters have already been written.
Since I had to remove the exprents because of the previous statement that means lexs canonical constructor detection no longer worked so I moved it with the compact canonical constructor detection where it checks if there's any exprents leftover after removing the field assignments
Fixes #108