Standardize float and double constants further#136
Merged
zml2008 merged 4 commits intoMar 4, 2023
Conversation
The smallest possible float/double is now calculated including rounding and truncating This resolves decompiling differences by running with J17 vs J19 by becoming more in line with J19 Fixes MinecraftForge#130
zml2008
approved these changes
Mar 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-sfn=1by default. This properties let you disable the behavior that calculates standardized versions of floating-point numbers to make the decompiled constants consistent across JVMs (although why would you ever want to disable this?)1.19.3 diff - there are no differences between 1.19.3 decompiled on J17 and J19 using this PR; so the diff was omitted
Fixes #130