Skip to content

[7.0] Slime Launcher config creation has questionable registration #989

@Jonathing

Description

@Jonathing

The configurations for the Slime Launcher runs are generated based off the contents of the metadata.zip file that is generated as an artifact from Mavenizer. Currently, ForgeGradle 7 handles this by querying this file at configuration and setting each run task's convention values to what is in the run configs stored in that ZIP file. However, this can cause problems as configuration is not always guaranteed to run.

Instead of reading the metadata.zip at configuration, it should instead be passed in as an input of SlimeLauncherExec. When the task is executed, it should process the metadata and set values for any properties that have none set, so that any defaults may be used where values are not declared in the buildscript.

This will have one changed with project import. Run configurations will now have to be validated when that run task is executed, and not when the project finished importing (in after evaluate). But this is way better than trying to locate and use a volatile file which may or may not exist, especially for new projects.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions