Skip to content

Update CREDITS.txt to fix typo#10542

Closed
walia6 wants to merge 1 commit intoMinecraftForge:1.21.xfrom
walia6:patch-1
Closed

Update CREDITS.txt to fix typo#10542
walia6 wants to merge 1 commit intoMinecraftForge:1.21.xfrom
walia6:patch-1

Conversation

@walia6
Copy link
Copy Markdown

@walia6 walia6 commented Apr 25, 2025

Fixed a grammatical error in CREDITS.txt: corrected "it's authors" to the proper possessive form "its authors" in a sentence crediting the javaxdelta library authors.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 25, 2025

CLA assistant check
All committers have signed the CLA.

@autoforge autoforge bot added Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. LTS This issue/PR is related to the current LTS version. 1.21 labels Apr 25, 2025
@autoforge autoforge bot requested a review from a team April 25, 2025 06:18
@Jonathing
Copy link
Copy Markdown
Member

Jonathing commented Apr 25, 2025

Right, so something like this is better reported as an issue so that it would be fixed alongside trivial updates to doc files when a recommended build is made, like how I updated the README for the repo when I made the last recommended builds.

If you're going to go out of your way to fix a single grammatical issue in a document, then you might as well spend the additional effort looking into other language issues within the other documents in this repository. I'm not a fan of merging single typo fixes.

Passing this over to Lex, he can do what he wants with this.

@Jonathing Jonathing requested review from LexManos and removed request for a team April 25, 2025 11:53
@Jonathing Jonathing removed the LTS This issue/PR is related to the current LTS version. label Apr 25, 2025
@LexManos
Copy link
Copy Markdown
Member

We're of the same stance.

@Jonathing
Copy link
Copy Markdown
Member

In that case, I'm closing this. I'll keep myself assigned so that I can make this change on the next RBs.

@Jonathing Jonathing added Assigned This request has been assigned to a core developer. Will not go stale. and removed Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. labels Apr 25, 2025
@Jonathing Jonathing self-assigned this Apr 25, 2025
@Jonathing Jonathing removed the request for review from LexManos April 25, 2025 13:56
@Jonathing Jonathing added the Trivial This request is considered to be low-effort. label Apr 25, 2025
@Jonathing Jonathing closed this Apr 25, 2025
@autoforge
Copy link
Copy Markdown

autoforge bot commented Apr 25, 2025

👋 Thank you for your contribution.
Unfortunately, we do not accept low effort PRs, be it typo fixes or trivial code formatting changes.
For inspiration or ideas, you can take a look at the open issues, or join our Discord server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.21 Assigned This request has been assigned to a core developer. Will not go stale. Trivial This request is considered to be low-effort.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants