Skip to content

fix: Address snapshot parsing in new versioning system #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LexManos merged 1 commit into from
Jul 1, 2026
+7 −5
Merged

fix: Address snapshot parsing in new versioning system #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/net/minecraftforge/srgutils/MinecraftVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@ else if (lower.startsWith("rd-")) {
// The new versioning system https://www.minecraft.net/en-us/article/minecraft-new-version-numbering-system
// They did not specify pre-release or release candidate naming system.
if (version.contains("-snapshot-")) {
String[] pts = version.split("-snapshot-");
return new MinecraftVersion(Type.SNAPSHOT, version, Integer.parseInt(pts[1]), -1, 0, null, splitDots(pts[0]));
String[] pts = version.split("-snapshot-", 2);
return new MinecraftVersion(Type.SNAPSHOT, version, Integer.parseInt(pts[1]), -1, 0, "", splitDots(pts[0]));
Comment thread
Dario-Maselli marked this conversation as resolved.
} else if (version.contains("-pre-")) { // New Numbering system pre-releases have {version}-pre-{number}
String[] pts = version.split("-pre-");
pre = Integer.parseInt(pts[1]);
Expand Down
8 changes: 5 additions & 3 deletions src/test/java/net/minecraftforge/srgutils/test/VersionList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@ public class VersionList {

//Just copy pasted with a little resorting from Mojang's version manifest, https://launchermeta.mojang.com/mc/game/version_manifest.json
//We can't read this file directly, because its in strict release date order, not target version order
private final String[] versions = new String[] {
"26.1-rc-2",
"26.1-rc-1",
private final String[] versions = new String[] {
"26.3-snapshot-2",
"26.3-snapshot-1",
"26.1-rc-2",
"26.1-rc-1",
"26.1-pre-3",
"26.1-pre-2",
"26.1-pre-1",
Expand Down