build: depend on :common properly#371
Merged
MattSturgeon merged 1 commit intoMinecraftFreecam:stonecutterfrom Mar 22, 2026
Merged
build: depend on :common properly#371MattSturgeon merged 1 commit intoMinecraftFreecam:stonecutterfrom
:common properly#371MattSturgeon merged 1 commit intoMinecraftFreecam:stonecutterfrom
Conversation
Apparently setting `group` in gradle buildscripts has a bunch of undocumented pitfalls, that in our case confuse gradle and lead to unexpected dependency cycles when projects depend on other projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently setting
groupin gradle buildscripts has a bunch of undocumented pitfalls, that in our case confuse gradle and lead to unexpected dependency cycles when projects depend on other projects.I was working around that by depending on
:common's sources, instead of the project's build artifacts.Dropping
group = meta.groupin the convention plugin allows us to use a "normal" project dependency in the loader convention. This should mean that:commonis compiled once, and the resulting classes are re-used by loader projects.