fix(setup-publish): download release asset directly#19
Merged
MattSturgeon merged 3 commits intomainfrom Apr 24, 2026
Merged
Conversation
Avoid using GitHub's REST API; it isn't accessible to other repos' fine-grained tokens. Instead, download directly from the CDN URL. This is also simpler, and allows us to do the download and hash verification in one go.
MattSturgeon
force-pushed
the
direct-download
branch
from
1c8a9cb to
d28972e
Compare
It won't exist until the next release.
MattSturgeon
force-pushed
the
direct-download
branch
from
d28972e to
13d5263
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid using GitHub's REST API; it isn't accessible to other repos' fine-grained tokens.
Instead, download directly from the CDN URL.
This is also simpler, and allows us to do the download and hash verification in one go.
Since we cannot get
digestfrom the assets REST API, we upload.sha256files with the release.