Skip to content

Conversation

@dshadowwolf
Copy link
Contributor

@dshadowwolf dshadowwolf commented Jun 28, 2017

  1. Extend the base API so users can specify a new feature generator using the mixed binary and IMC method
  2. Extend DimensionLogic so the feature-name can be passed in as a string
  3. Remove the OreSpawn2 json format writer as it was only used during development
  4. Remove the "getMaxHeight" and related calls from the SpawnEntry API (only used in the OS2 json writer)
  5. simplify the code in DimensionLogic to add parameters and call down to a single point-of-failure
  6. simplify SpawnEntry to only have the one constructor that is being used
  7. Extend the FeatureRegistry to allow for registering by name&classpath instead of with a chunk of JSON.
  8. Remove some code duplication in the FeatureRegistry and fix a potential bug when a feature has been loaded from _features.json and specified by a mod using the API
  9. Add a command that causes the system to write-out the current configuration immediately

…run-time. The feature will be added to _features.json if it is written out after this point.
…this code up so it calls down to a single point that actually creates and registers the SpawnEntry. This removes duplicated code and simplifies a lot of the logic.
…awn v2 json writer and also remove that format writer, as it is not needed
…tuation in which two feature generators of the same name are registered. This fixes the potential issue where the feature is in _features.json and the mod that added it has made the API calls that originally added it
@dshadowwolf dshadowwolf merged commit f72e28d into MinecraftModDevelopmentMods:v3 Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant