Fix: Hotspot Index Out-of-Bounds Error in Nanobody Sampling#28
Open
RicardoZF wants to merge 1 commit into
Open
Fix: Hotspot Index Out-of-Bounds Error in Nanobody Sampling#28RicardoZF wants to merge 1 commit into
RicardoZF wants to merge 1 commit into
Conversation
Problem: - hotspot_index was calculated on the full structure (including non-standard residues) - Data is later filtered by modeled_idx (keeping only standard amino acids) - Saved hotspot indices were not mapped to the filtered space - This caused IndexError when indices exceeded the filtered array size Example: - Original structure: 196 residues - After filtering: 188 residues (modeled_seq_len) - Hotspot indices: [146, 157, 173, 179] (based on original structure) - Error: index 179 > 188, out of bounds Solution: Map hotspot indices to the modeled_idx space before saving to metadata. Co-Authored-By: RicardoZF <1370174361@qq.com>
y1zhou
added a commit
to y1zhou/PPIFlow
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Example:
Solution:
Map hotspot indices to the modeled_idx space before saving to metadata.