Skip to content

fix: resolve error raised by unneeded scripts#4

Merged
Mini-ghost merged 2 commits intoMini-ghost:mainfrom
ennioVisco:patch-1
Jul 30, 2023
Merged

fix: resolve error raised by unneeded scripts#4
Mini-ghost merged 2 commits intoMini-ghost:mainfrom
ennioVisco:patch-1

Conversation

@ennioVisco
Copy link
Copy Markdown
Contributor

@ennioVisco ennioVisco commented Jul 28, 2023

Coming from nuxt/nuxt#22212!

Sorry for the late reply, I needed to find the time to test it properly :)

There is currently this minor issue that I believe should be addressed, it is not safe to assume users of the module have husky installed!

@ennioVisco
Copy link
Copy Markdown
Contributor Author

ennioVisco commented Jul 28, 2023

Actually, it's much worse, it seems that the husky preparation scripts are failing (and I see no clear way to fix them) when the module is installed as a dependency.
How did you deal with this in your use case?

Screenshot 2023-07-28 at 17 01 52

@Mini-ghost
Copy link
Copy Markdown
Owner

It was my mistake; I should have removed postinstall in the scripts. Can you help me to remove it?

@ennioVisco
Copy link
Copy Markdown
Contributor Author

ennioVisco commented Jul 29, 2023

Ok, @Mini-ghost I can confirm that with this change the installation succeeds.
But now I have this other issue:
image

@Mini-ghost
Copy link
Copy Markdown
Owner

@ennioVisco

I tried running the playground on your branch, but I didn't find the error. Can you tell me the steps to reproduce it? Also this seems to be another question, can I merge this PR first?

@ennioVisco
Copy link
Copy Markdown
Contributor Author

@ennioVisco

I tried running the playground on your branch, but I didn't find the error. Can you tell me the steps to reproduce it? Also this seems to be another question, can I merge this PR first?

You're right, this is another problem. I believe you can merge this :)

@Mini-ghost Mini-ghost changed the title Fixed build for users not having husky installed fix: resolve error raised by unneeded scripts Jul 30, 2023
@Mini-ghost Mini-ghost merged commit cea74f7 into Mini-ghost:main Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants