feat(errors): improve global error interception for filesystem, network and format errors#35
Merged
MiniMax-AI-Dev merged 2 commits intomainfrom Apr 6, 2026
Merged
Conversation
…rk and format errors - Add SIGINT handler (exit 130) in main.ts - Detect filesystem errors (ENOENT/EACCES/ENOSPC/EPERM/EBUSY/EISDIR/ENOTDIR) with specific hints, plus catch-all for other "E" prefix Node.js codes - Detect TypeError "fetch failed" as network error with MINIMAX_BASE_URL hint - Handle non-JSON API responses gracefully in requestJson - Warn when credentials file is corrupted (credentials.ts) - Warn when config file is corrupted (loader.ts) - Add ERRORS.md documenting all error scenarios for all commands
Collaborator
|
这个改动有价值 ，但是 CI 没过 |
Collaborator
Author
|
好的，我来处理 |
The handler.ts uses ExitCode.NETWORK but NETWORK was not defined in the ExitCode enum, causing TypeScript error TS2339 during CI typecheck.
Collaborator
Author
|
@MiniMax-AI-Dev Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main.tsEprefix Node.js error codesTypeError: fetch failedas network error withMINIMAX_BASE_URLformat hintrequestJsoncredentials.ts)loader.ts)ERRORS.mddocumenting all error scenarios for all commandsTest plan
minimax text chat --message helloand verify error handling worksMINIMAX_BASE_URLand verify friendly errorERRORS.mdcovers all documented error scenarios