fix(speech): use correct file extension for default output filename#63
Merged
RyanLee-Dev merged 1 commit intoMiniMax-AI:mainfrom Apr 9, 2026
Merged
Conversation
When --format is specified without --out, the default output filename always used .mp3 regardless of the requested format. For example, --format wav would produce speech_xxx.mp3 containing WAV audio data, causing tools that rely on file extensions to misidentify the format. Fix: derive the extension from --format flag (defaulting to mp3). Note: music/generate.ts already handles this correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
--formatis specified without--out, the default output filename always used.mp3regardless of the requested format:This means the file extension does not match the actual audio format. Tools that rely on file extensions (ffmpeg, audio editors, upload APIs, scripts) will misidentify or fail to process the file.
Fix
Derive the extension from the
--formatflag, defaulting tomp3when not specified:This only affects the auto-generated filename. Users who explicitly pass
--out <path>are unaffected.Note:
music/generate.tsalready handles this correctly — this bringsspeech/synthesize.tsin line with the same pattern.Reproduction
After fix: