Skip to content

Fixed TransferProduct ejectile energy and theta calculations in LAB and CoM frame#60

Merged
lpgaff merged 6 commits intoMiniball:mainfrom
Pezkoo:main
Jul 21, 2025
Merged

Fixed TransferProduct ejectile energy and theta calculations in LAB and CoM frame#60
lpgaff merged 6 commits intoMiniball:mainfrom
Pezkoo:main

Conversation

@Pezkoo
Copy link
Contributor

@Pezkoo Pezkoo commented Jul 14, 2025

Fixed ejectile energy and theta calculations in LAB and CoM frame + fixed beta calculation

@Pezkoo
Copy link
Contributor Author

Pezkoo commented Jul 14, 2025

This is now being merged to the main branch, but is it still possible to create a new branch where this change is merged to?

@lpgaff
Copy link
Contributor

lpgaff commented Jul 14, 2025

This is now being merged to the main branch, but is it still possible to create a new branch where this change is merged to?

We can test it from your own branch/fork by making a clone of it with a different name at CERN. As we fix any bugs or make updates, you can just push the changes as normal and this Pull Request will update. Then when we're happy that it works, we can merge it to the main branch.

@lpgaff
Copy link
Contributor

lpgaff commented Jul 21, 2025

Great work! Thanks Vili, this is wonderful.

Still a few more steps to correctly account for the energy loss and the annoying user options, but we can merge now and tweak that later.

Once everything is working nicely, we should port this over to the CalculateRecoil and CalculateEjectile functions.

But for the upcoming experiment, this is the priority, so let's merge!

@lpgaff lpgaff merged commit f43c64a into Miniball:main Jul 21, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants