Skip to content

Fixed missing dep for "make -j". From Hans T. fix of ISSSort.#7

Merged
lpgaff merged 1 commit intoMiniball:mainfrom
inkdot7:make_j
Feb 23, 2024
Merged

Fixed missing dep for "make -j". From Hans T. fix of ISSSort.#7
lpgaff merged 1 commit intoMiniball:mainfrom
inkdot7:make_j

Conversation

@inkdot7
Copy link
Contributor

@inkdot7 inkdot7 commented Sep 23, 2023

@lpgaff
Copy link
Contributor

lpgaff commented Oct 7, 2023

I'm holding off on this, because during testing of that in ISSSort, it was giving strange behaviour of the dictionary file names and locations on some systems.

@inkdot7
Copy link
Contributor Author

inkdot7 commented Oct 8, 2023

@lpgaff Could you elaborate on the issues seen with make -j in ISSSort so we can try to fix those? @hanstt

@lpgaff
Copy link
Contributor

lpgaff commented Feb 9, 2024

Sorry, just coming back to this. With the changes to the Makefile, it seems that the ROOT dictionaries are compiled with strange names, like the suffix is added twice to the filename. It might be that different versions of make interpret the extra argument in different ways?

@inkdot7
Copy link
Contributor Author

inkdot7 commented Feb 10, 2024

I could reproduce the error. The issue was that with those two dependencies $(ROOTDICT) would be called twice, and when called for the _rdict.pcm file it generated one with _rdict_rdict.pcm name. It actually makes both the .cc file and then _rdict.pcm file at once, so the needed thing is to tell that the .pcm depends on the .cc.

If it works for you too, I can make a MR for ISSSort as well, unless you beat me to it :-)

@lpgaff lpgaff merged commit bf78cdc into Miniball:main Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants