Skip to content

chore(issue-feed): remove deprecated backward-compat inputs#29

Merged
lml2468 merged 1 commit into
mainfrom
feat/issue-feed-cleanup-deprecated
May 19, 2026
Merged

chore(issue-feed): remove deprecated backward-compat inputs#29
lml2468 merged 1 commit into
mainfrom
feat/issue-feed-cleanup-deprecated

Conversation

@lml2468
Copy link
Copy Markdown
Contributor

@lml2468 lml2468 commented May 19, 2026

Summary

Removes issue_labels and project_group_id deprecated inputs from octo-issue-feed.yml reusable workflow.

Pre-conditions verified

  • All 8 callers migrated to @main without passing these inputs ✅
    octo-server  issue_labels=NO  project_group_id=NO  ref=@main
    octo-web     issue_labels=NO  project_group_id=NO  ref=@main
    octo-adapters issue_labels=NO project_group_id=NO  ref=@main
    octo-matter  issue_labels=NO  project_group_id=NO  ref=@main
    ... (all 8 clean)
    

What changed

Pure deletion — 14 lines removed, zero lines added:

Verification checklist

  • issue_labels removed ✅
  • project_group_id removed ✅
  • No ISSUE_LABELS / PROJECT_GROUP_ID env var references ✅
  • No labels_part / proj_gid / proj_msg references ✅
  • require_group_id removed ✅
  • 7 clean inputs remain: repo_name, issue_number, issue_title, issue_url, issue_author, event_action, api_base_url ✅
  • YAML valid ✅

Next steps after merge

  1. Cut v2 tag pointing at this commit
  2. Update 8 callers from @main@v2

All 8 callers have been migrated to @main and no longer pass
issue_labels or project_group_id. Remove the deprecated optional
inputs and their associated no-op blocks.

Verified: grep for issue_labels, project_group_id, ISSUE_LABELS,
PROJECT_GROUP_ID, labels_part, proj_gid, require_group_id all return
empty in the resulting file.
Copy link
Copy Markdown

@Jerry-Xin Jerry-Xin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: Relevant, narrowly scoped cleanup of the .github reusable issue-feed workflow with no blocking issues found.

💬 Non-blocking

🟡 Warning — .github/workflows/octo-issue-feed.yml: Removing workflow_call inputs is breaking for any caller that still passes issue_labels or project_group_id. This checkout has no local octo-issue-feed callers to verify, so merge safety depends on the external caller audit in the PR description. Given that all known callers are reported migrated, this is not blocking.

✅ Highlights

🔵 Suggestion — The change is a pure schema cleanup: only deprecated ignored inputs were removed, with no runtime notification logic changed.

✅ Verified locally: YAML parses successfully, actionlint passes for octo-issue-feed.yml, and no issue_labels, PROJECT_GROUP_ID, labels_part, proj_gid, proj_msg, or require_group_id references remain in this workflow.

Copy link
Copy Markdown
Contributor Author

@lml2468 lml2468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Removes the deprecated issue_labels and project_group_id inputs from octo-issue-feed.yml that were kept for backward compatibility in PR #28.

Findings

None. Verified all 8 downstream callers have already been updated:

Repo issue_labels project_group_id
octo-server ✅ removed ✅ removed
octo-web ✅ removed ✅ removed
octo-adapters ✅ removed ✅ removed
octo-deployment ✅ removed ✅ removed
octo-matter ✅ removed ✅ removed
octo-smart-summary ✅ removed ✅ removed
octo-admin ✅ removed ✅ removed
octo-lib ✅ removed ✅ removed

The deprecation cycle is complete: PR #28 added the no-ops → callers cleaned up → this PR removes the no-ops. Textbook backward-compatible deprecation.

Verdict

APPROVED — safe to merge, all callers confirmed clean. (Submitted as COMMENTED due to GitHub limitation.)

@lml2468 lml2468 merged commit db07458 into main May 19, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants