fix: Incorrect added token can cause issues when adding token as multiword token#319
Merged
stephantul merged 4 commits intomainfrom Apr 14, 2026
Merged
fix: Incorrect added token can cause issues when adding token as multiword token#319stephantul merged 4 commits intomainfrom
stephantul merged 4 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Pringled
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current version of model2vec it is possible to attempt adding a multiword added token if the token is already present in the vocabulary. This happens in the following circumstances:
The logic bug is as follows: we don't check whether multiword tokens are already present in the original tokenizers vocabulary. Therefore, we try to add the same token twice. This assumption is sound, because normally a tokenizer's vocabulary can't contain tokens that are preprocessed into multiple tokens.