Add db-schema config #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tifrel
approved these changes
Jan 22, 2024
| ethrpc = "http://localhost:8545" | ||
|
|
||
| [database.sqlite] | ||
| connection = "file:arak.db" |
Member
There was a problem hiding this comment.
Is this required despite us not using SQLite?
Member
Author
There was a problem hiding this comment.
SQLite is used for testing. It essential purpose is to be a functional environment that doesn't depend on an existing DB server (i.e. can run arak entirely within the existing filesystem). I think it would be quite a bit of work to migrate out of the project and for little benefit.
| [database.sqlite] | ||
| connection = "file:arak.db" | ||
|
|
||
| #[database.postgres] |
Member
Author
There was a problem hiding this comment.
Because the example file doesn't give an example of postgres (which is our primary purpose). Just wanted the potential user to be aware of how that it configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In alignment with Mintbase/evm-indexer#120, we add a schema configuration to the arak event-listening service.
This will require a change to our existing deployment:
Namely