Skip to content

Conversation

@sebhmg
Copy link

@sebhmg sebhmg commented Aug 5, 2024

DEVOPS-452 - apply latest version of python template repos to all repos

address Ruff reports

sebhmg added 4 commits August 5, 2024 17:47
which are instance members
proper fix would require introducing a classmethod with memoization
@github-actions github-actions bot changed the title Devops 452 address ruff DEVOPS-452: address ruff Aug 5, 2024
@sebhmg sebhmg requested a review from Swendart August 5, 2024 21:54
@codecov
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.31%. Comparing base (5becb3b) to head (a46430c).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #68      +/-   ##
===========================================
- Coverage    93.32%   93.31%   -0.01%     
===========================================
  Files           28       28              
  Lines         1454     1452       -2     
===========================================
- Hits          1357     1355       -2     
  Misses          97       97              
Files Coverage Δ
omf/fileio/geoh5.py 93.45% <100.00%> (-0.03%) ⬇️

should still be address properly. Leave as TODO
@sebhmg sebhmg merged commit fbbf0b7 into MiraGeoscience:develop Aug 7, 2024
@sebhmg sebhmg deleted the DEVOPS-452-address-Ruff branch August 7, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant