DEVOPS-420 - Sharing pre-commit-hooks script in a python package#1
DEVOPS-420 - Sharing pre-commit-hooks script in a python package#1
Conversation
sebhmg
left a comment
sebhmg
left a comment
There was a problem hiding this comment.
see some suggestion and questions
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: Sébastien Hensgen <sebastienh@mirageoscience.com>
Co-authored-by: Sébastien Hensgen <sebastienh@mirageoscience.com>
sebhmg
left a comment
sebhmg
left a comment
There was a problem hiding this comment.
some more suggestions. Nothing big, getting to the end !
sebhmg
left a comment
sebhmg
left a comment
There was a problem hiding this comment.
Please see:
- one small correction in.pre-commit config
- suggestion for using company namespace according to PEP423
sebhmg
left a comment
sebhmg
left a comment
There was a problem hiding this comment.
looks good!
Projet and package name are good.
Not 100% sure having . in the repo name, since already under MiraGeoscience org. Maybe it could be pre-commit-hooks? Anyway, good to go as is !
sebhmg
left a comment
sebhmg
left a comment
There was a problem hiding this comment.
Not 100% sure having
.in the repo name, since already under MiraGeoscience org. Maybe it could bepre-commit-hooks? Anyway, good to go as is !
After second thought, looking at https://github.com/MiraGeoscience/python-poetry-template/blob/main/.pre-commit-config.yaml, It think just http://github.com/MiraGeoscience/pre-commit-hooks looks better.
That one be the one last change here: renaming this repo, before making all other repos pointing to this one...
|
Perfect. I renamed it! |
sebhmg
left a comment
sebhmg
left a comment
There was a problem hiding this comment.
- fix URL in config file after repo renamed
- minor: indentation style
Co-authored-by: Sébastien Hensgen <sebastienh@mirageoscience.com>
2 participants
DEVOPS-420 - Sharing pre-commit-hooks script
Description
Introduction of a Python package that bundles pre-configured Git hooks, facilitating their reuse and standardizing development practices within the team.
Warning points
After step