Skip to content

Conversation

@domfournier
Copy link
Collaborator

@domfournier domfournier commented Sep 17, 2025

GEOPY-2440 - add a copy group+object base in inputfile as it exists uin uijhson group

@github-actions github-actions bot changed the title GEOPY-2440 GEOPY-2440: add a copy group+object base in inputfile as it exists uin uijhson group Sep 17, 2025
@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.75%. Comparing base (17a64b1) to head (5f096cf).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
simpeg_drivers/driver.py 75.00% 1 Missing and 1 partial ⚠️
simpeg_drivers/line_sweep/driver.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #275      +/-   ##
===========================================
+ Coverage    91.72%   91.75%   +0.02%     
===========================================
  Files          110      110              
  Lines         5873     5879       +6     
  Branches       714      715       +1     
===========================================
+ Hits          5387     5394       +7     
+ Misses         306      304       -2     
- Partials       180      181       +1     
Files with missing lines Coverage Δ
simpeg_drivers/joint/driver.py 90.76% <100.00%> (+0.03%) ⬆️
simpeg_drivers/plate_simulation/driver.py 79.14% <100.00%> (+0.12%) ⬆️
simpeg_drivers/driver.py 85.14% <75.00%> (-0.31%) ⬇️
simpeg_drivers/line_sweep/driver.py 93.15% <71.42%> (+1.99%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@MatthieuCMira MatthieuCMira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why storing out_group 2 times at different places?

@MatthieuCMira MatthieuCMira self-requested a review September 17, 2025 20:22
Copy link
Contributor

@MatthieuCMira MatthieuCMira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me

@domfournier domfournier merged commit b9e9be4 into develop Sep 17, 2025
14 checks passed
@domfournier domfournier deleted the GEOPY-2440 branch September 17, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants