GEOPY-1029: Add datetime stamp to simpeg.log and simpeg.out file names#385
Merged
domfournier merged 8 commits intorelease/GA_4.8from Apr 23, 2026
Merged
GEOPY-1029: Add datetime stamp to simpeg.log and simpeg.out file names#385domfournier merged 8 commits intorelease/GA_4.8from
domfournier merged 8 commits intorelease/GA_4.8from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates SimPEG driver log/artifact naming to be based on the workspace filename stem (e.g., inversion_test.ui.log/.out) and bumps the mira-simpeg dependency to a revision that supports the new behavior.
Changes:
- Rename generated log/output artifacts from fixed names (
SimPEG.log/.out,ChiFactors.log) to workspace-stem-based names (<stem>.log/.out,<stem>.chi). - Adjust gravity run tests to assert against the new artifact names.
- Update
mira-simpeggit revision and refresh conda lockfiles accordingly.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/run_tests/driver_grav_test.py | Updates assertions to use <workspace_stem>.log/.out names and reorders the memory-error test. |
| simpeg_drivers/driver.py | Changes logger path generation to use <workspace_stem>.log and removes log file overwrite behavior. |
| simpeg_drivers/components/factories/directives_factory.py | Passes workspace stem into log-saving directive and renames chi-factor file to <stem>.chi. |
| pyproject.toml | Pins mira-simpeg to GEOPY-1029C to pick up required upstream changes. |
| py-3.13.conda-lock.yml | Updates locked mira-simpeg source revision/hash. |
| py-3.12.conda-lock.yml | Updates locked mira-simpeg source revision/hash. |
| environments/py-3.13-win-64.conda.lock.yml | Refreshes env lock to new mira-simpeg commit. |
| environments/py-3.13-win-64-dev.conda.lock.yml | Refreshes env lock to new mira-simpeg commit. |
| environments/py-3.13-linux-64.conda.lock.yml | Refreshes env lock to new mira-simpeg commit. |
| environments/py-3.13-linux-64-dev.conda.lock.yml | Refreshes env lock to new mira-simpeg commit. |
| environments/py-3.12-win-64.conda.lock.yml | Refreshes env lock to new mira-simpeg commit. |
| environments/py-3.12-win-64-dev.conda.lock.yml | Refreshes env lock to new mira-simpeg commit. |
| environments/py-3.12-linux-64.conda.lock.yml | Refreshes env lock to new mira-simpeg commit. |
| environments/py-3.12-linux-64-dev.conda.lock.yml | Refreshes env lock to new mira-simpeg commit. |
Comments suppressed due to low confidence (1)
simpeg_drivers/driver.py:794
InversionLogger.start()no longer clears an existing log file, butwrite()always opens the log in append mode. Re-running in the same directory/workspace stem will silently mix logs from multiple runs, which can make debugging and any downstream parsing unreliable. Consider truncating/overwriting the log at the start of a run (e.g., open once in write mode, or explicitly delete/rotate the existing file) before writing the header.
def start(self):
self.write(
f"Running simpeg-drivers {__version__}\n"
f"Started {self.start_date_time}\n"
f"{self.driver.params.title}\n"
)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MatthieuCMira
requested changes
Apr 23, 2026
Contributor
MatthieuCMira
left a comment
There was a problem hiding this comment.
do not merge with a toml file pointing to a branch.
MatthieuCMira
previously approved these changes
Apr 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/GA_4.8 #385 +/- ##
==================================================
- Coverage 90.27% 90.26% -0.01%
==================================================
Files 132 132
Lines 6475 6469 -6
Branches 815 814 -1
==================================================
- Hits 5845 5839 -6
Misses 420 420
Partials 210 210
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-1029 - Add datetime stamp to simpeg.log and simpeg.out file names