Skip to content

GEOPY-2879: Allow rotated receivers for ground EM survey#413

Merged
domfournier merged 3 commits into
release/GA_4.8from
GEOPY-2879
May 25, 2026
Merged

GEOPY-2879: Allow rotated receivers for ground EM survey#413
domfournier merged 3 commits into
release/GA_4.8from
GEOPY-2879

Conversation

@domfournier
Copy link
Copy Markdown
Collaborator

@domfournier domfournier commented May 21, 2026

GEOPY-2879 - Allow rotated receivers for ground EM survey

Copilot AI review requested due to automatic review settings May 21, 2026 22:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends receiver orientation handling in the SimPEG receivers factory to support Large Loop Ground EM surveys, aligning ground EM behavior with existing airborne EM behavior when per-receiver orientations are required.

Changes:

  • Import LargeLoopGroundEMSurvey alongside AirborneEMSurvey.
  • Apply the per-receiver orientation override for LargeLoopGroundEMSurvey in addition to AirborneEMSurvey when local_indices are provided.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.43%. Comparing base (13cfaed) to head (6208ab7).

Additional details and impacted files
@@               Coverage Diff               @@
##           release/GA_4.8     #413   +/-   ##
===============================================
  Coverage           90.43%   90.43%           
===============================================
  Files                 110      110           
  Lines                6532     6535    +3     
  Branches              826      827    +1     
===============================================
+ Hits                 5907     5910    +3     
  Misses                413      413           
  Partials              212      212           
Files with missing lines Coverage Δ
...g_drivers/components/factories/receiver_factory.py 90.51% <100.00%> (+0.25%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier domfournier merged commit 42b7155 into release/GA_4.8 May 25, 2026
16 checks passed
@domfournier domfournier deleted the GEOPY-2879 branch May 25, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants