GEOPY-2015: Add tooltips to missing IP inversion inputs#414
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds user-facing tooltips to the DC and IP 3D inversion UI JSON definitions to improve parameter guidance in the SimPEG drivers UI.
Changes:
- Added tooltips for DC data selection (object, channel, uncertainty) and model bounds.
- Added tooltips for IP data selection (object, channel, uncertainty).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| simpeg_drivers-assets/uijson/induced_polarization_3d_inversion.ui.json | Adds data-selection tooltips for IP 3D inversion inputs. |
| simpeg_drivers-assets/uijson/direct_current_3d_inversion.ui.json | Adds data-selection and bound-setting tooltips for DC 3D inversion inputs. |
Comments suppressed due to low confidence (3)
simpeg_drivers-assets/uijson/direct_current_3d_inversion.ui.json:29
- Wording: "containing the potentials" is a bit unclear/inconsistent with the label "Potential (V/I)". Consider using "potential values" / "potential data" for clearer user-facing text.
"main": true,
"label": "Potential (V/I)",
"tooltip": "Select a data channel containing the potentials.",
"parent": "data_object",
"value": ""
simpeg_drivers-assets/uijson/direct_current_3d_inversion.ui.json:42
- This tooltip has a double space after the period and the phrase "a data percent" reads awkwardly. Please clean up the spacing and reword the guidance (e.g., describe it as a percent uncertainty plus a small floor) to make the tooltip clearer.
"isValue": true,
"label": "Uncertainty",
"tooltip": "Choose a representative uncertainty level for the potential data. Can be a scalar or per datum. For DC data a data percent + small floor approach is often used.",
"parent": "data_object",
simpeg_drivers-assets/uijson/direct_current_3d_inversion.ui.json:112
- Grammar issue: "Set an lower bound ... either cell-based on as a constant value" is ungrammatical and unclear. Please rephrase (e.g., "Set a lower bound ... either as a constant value or as a cell-based model").
"optional": true,
"value": 1e-08,
"tooltip": "Set an lower bound for the conductivity model, either cell-based on as a constant value",
"enabled": false
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "group": "Data", | ||
| "main": true, | ||
| "label": "Chargeability (V/V)", | ||
| "tooltip": "Select a data channel containing chargeabilities.", |
Comment on lines
13
to
16
| "label": "Object", | ||
| "meshType": "{275ecee9-9c24-4378-bf94-65f3c5fbe163}", | ||
| "tooltip": "Select a Potential Electrode object containing potentials data.", | ||
| "value": "" |
domfournier
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2015 - Add tooltips to missing IP inversion inputs