GEOPY-2773: Airborne FEM coaxial do not rotate transmitter, and ppm normalization needs to be ajusted#142
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Dask-based frequency-domain EM sensitivity assembly to correctly advance column offsets during block-wise row computation and to size parallel blocks according to the available thread count.
Changes:
- Increment the running column offset (
count) insidecompute_rowsfor each receiver-derivative block. - Pass
thread_count=n_threadsintoget_parallel_blocksso block sizing reflects available parallelism. - Simplify the non-distributed (
client is None) delayed execution path by removing unused variables and avoidingarray.from_delayed(...)wrapping forcompute_rows(which performs in-place writes).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2773 - Airborne FEM coaxial do not rotate transmitter, and ppm normalization needs to be ajusted