Skip to content

GEOPY-2773: Airborne FEM coaxial do not rotate transmitter, and ppm normalization needs to be ajusted#142

Merged
domfournier merged 1 commit into
release/GA_4.8from
GEOPY-2773B
May 1, 2026
Merged

GEOPY-2773: Airborne FEM coaxial do not rotate transmitter, and ppm normalization needs to be ajusted#142
domfournier merged 1 commit into
release/GA_4.8from
GEOPY-2773B

Conversation

@domfournier
Copy link
Copy Markdown

@domfournier domfournier commented May 1, 2026

GEOPY-2773 - Airborne FEM coaxial do not rotate transmitter, and ppm normalization needs to be ajusted

Copilot AI review requested due to automatic review settings May 1, 2026 06:31
@github-actions github-actions Bot changed the title GEOPY-2773 GEOPY-2773: Airborne FEM coaxial do not rotate transmitter, and ppm normalization needs to be ajusted May 1, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Dask-based frequency-domain EM sensitivity assembly to correctly advance column offsets during block-wise row computation and to size parallel blocks according to the available thread count.

Changes:

  • Increment the running column offset (count) inside compute_rows for each receiver-derivative block.
  • Pass thread_count=n_threads into get_parallel_blocks so block sizing reflects available parallelism.
  • Simplify the non-distributed (client is None) delayed execution path by removing unused variables and avoiding array.from_delayed(...) wrapping for compute_rows (which performs in-place writes).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@domfournier domfournier merged commit 6ea5b9d into release/GA_4.8 May 1, 2026
16 checks passed
@domfournier domfournier deleted the GEOPY-2773B branch May 1, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants