GEOPY-2866: Research auto-scaling strategy for cross-gradient regularization terms#143
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the cross-gradient regularization to use the standard SimPEG weight infrastructure (via set_weights / W) and introduces a new joint-inversion directive intended to scale cross-gradient weights based on model-gradient derivative magnitudes.
Changes:
- Refactors
CrossGradientto construct and apply its weighting operator through a newWproperty and stored weights (including cell volumes). - Adds a new inversion directive to rescale cross-gradient weights at the end of each iteration.
- Exposes the new directive through
simpeg.directives.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
simpeg/regularization/cross_gradient.py |
Moves cross-gradient weighting to set_weights + cached W operator; updates default units value. |
simpeg/directives/_sim_directives.py |
Adds a directive that computes a scale from model ranges and updates CrossGradient weights each iteration. |
simpeg/directives/__init__.py |
Re-exports the new directive from the top-level directives package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
benk-mira
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2866 - Research auto-scaling strategy for cross-gradient regularization terms