Regularization edits #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly changes how defaults are instatiated - includes a little more safety when setting `active_cells` on the `regularization_mesh` - Includes changes to weight interaction to guard against poor behavoir a little more.
domfournier
reviewed
Jul 15, 2022
domfournier
reviewed
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are my edits for the regularization PR.
Mostly it adjusts the instantiation behavior to set default values on
__init__.However, it also adds a few properties that should make setting
active_cellssafer, such as clearing any cached properties on the regmesh if it is changed fromNoneto something else. (This might also make it possible to allow for more changes to theactive_cellsinstead of just the first, but this wasn't something I thoroughly tested.)A bit of renaming to be more precise,
cellDiffxis now renamedcell_gradient_xas it was actually a cell gradient and not just a difference now.I've also include a safer handling of the weights, which should be double checked. Essentially it hides the
weightsdictionary from the user, and only allows interraction with it through three functions on the regularizationset_weights,get_weightsandremove_weights. Just as a personal preferenceset_weightsnow only accepts keywords arguments, but stores them on the internal_weightsdictionary as_weights[keyword] = argumenti.e.set_weights(irls=my_weights)will store it as_weights['irls"] = my_weightsAlso include a bit of namespace cleanup by hiding a few of the internal properties and functions that are not necessarily used by an end-user.