test(factory): fix deploy signature in tests and add Soroban unit tests#103
Merged
Miracle656 merged 1 commit intoMiracle656:mainfrom Apr 25, 2026
Merged
Conversation
- Update mock-wallet init to accept rp_id and origin (matching factory's call) - Fix all client.deploy/try_deploy calls to pass rp_id and origin - Add make_rp_id and make_origin helpers to test module - Add test_duplicate_deploy_prevented (same key, different domain blocked) - Add test_deploy_full_integration (address distinct, signer registered, duplicate blocked) - Delete stale snapshots (will regenerate on next cargo test run) - Add rust-toolchain.toml pinning 1.85.0 Note: cargo test is temporarily blocked by the stellar-xdr/arbitrary incompatibility tracked in issue Miracle656#79 on the upstream repo. Closes Miracle656#85
|
@Depo-dev is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Depo-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The factory contract deploy function signature was updated to accept rp_id and origin (matching the real invisible_wallet.init), but the test module still called client.deploy with only the public key. This PR fixes that mismatch and adds two new test cases.
What was changed
Known limitation
cargo test is currently blocked by the stellar-xdr 20.1.0 / arbitrary crate incompatibility tracked in issue #79. The test code is logically correct and will pass once that upstream issue is resolved.
Closes #85