Upgrade engines on MSR hosts individually to avoid downtime#265
Merged
Conversation
kke
added
the
non-breaking change
kke
changed the title
kke
commented
Dec 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it is quite easy to end up in a situation where all the MSR hosts are down simultaneously during the upgrade.
(for example, with 18 worker nodes and 2 msr nodes, when performing the upgrades in 10% chunks, the two msr nodes will be upgraded simultaneously)
This PR changes the engine upgrades on MSR hosts happen individually like it is already done for the managers. After the upgrade a healthcheck is performed, if the MSR did not resume, the upgrade process will be halted.
I doubt anyone has so many MSR hosts that running the upgrades in 10% batches like for the MKE workers would make much change in process duration.
(reported by @mgueye01 on slack)