Skip to content

PRODENG- vendor updates 2024/01#410

Merged
james-nesbitt merged 1 commit into
Mirantis:masterfrom
james-nesbitt:PRODENG-2513-mod-updates
Feb 7, 2024
Merged

PRODENG- vendor updates 2024/01#410
james-nesbitt merged 1 commit into
Mirantis:masterfrom
james-nesbitt:PRODENG-2513-mod-updates

Conversation

@james-nesbitt
Copy link
Copy Markdown
Collaborator

  • all go mod libraries updated
    • go-playground/validator required two small changes
    • k0sproject/rig update is quite large, so needs testing

@james-nesbitt james-nesbitt marked this pull request as draft February 1, 2024 10:30
@james-nesbitt
Copy link
Copy Markdown
Collaborator Author

james-nesbitt commented Feb 1, 2024

discovered some issues with winrm hosts, so I turned this into a draft PR:

FATA failed on 2 hosts:
 - [winrm] 54.160.196.218:5986: All attempts fail:
#1: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#2: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#3: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#4: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#5: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#6: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#7: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#8: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#9: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#10: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
 - [winrm] 34.238.159.167:5986: All attempts fail:
#1: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#2: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#3: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#4: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#5: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#6: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#7: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#8: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#9: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null.
#10: invalid path: open remote file C:\Users\Administrator\installerWindows3399842783.ps1 for writing: open: open C:\Users\Administrator\installerWindows3399842783.ps1: remote error: Cannot bind argument to parameter 'Path' because it is null

It looks like it is an issue with the windows installer, but I can't be sure. Without windows hosts we have no problem.

@kke
Copy link
Copy Markdown
Collaborator

kke commented Feb 1, 2024

Could be a bug in rig

@kke
Copy link
Copy Markdown
Collaborator

kke commented Feb 1, 2024

I'm not 100% sure if this is the problem:

// InstallMCR install MCR on Windows.
func (c WindowsConfigurer) InstallMCR(h os.Host, scriptPath string, engineConfig common.MCRConfig) error {
	pwd := c.Pwd(h)
	base := path.Base(scriptPath)
	installer := pwd + "\\" + base + ".ps1"
	err := h.Upload(scriptPath, installer)

I think rig expects / separated paths for Upload.

@kke
Copy link
Copy Markdown
Collaborator

kke commented Feb 5, 2024

Yep, I bumped into the same error, this fixed it for me: k0sproject/rig#165

@kke
Copy link
Copy Markdown
Collaborator

kke commented Feb 5, 2024

It's now released as v0.17.5

- all go mod libraries updated
	- go-playground/validator required two small changes
	- k0sproject/rig update is quite large, so needs testing

Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
@james-nesbitt
Copy link
Copy Markdown
Collaborator Author

just pulled it in, and am finishing testing now.

@james-nesbitt
Copy link
Copy Markdown
Collaborator Author

latest force push is a rebase.

@james-nesbitt james-nesbitt marked this pull request as ready for review February 6, 2024 11:56
@james-nesbitt
Copy link
Copy Markdown
Collaborator Author

k0sproject/rig#165 did resolve the issue.

@james-nesbitt james-nesbitt merged commit 58709b3 into Mirantis:master Feb 7, 2024
@james-nesbitt james-nesbitt deleted the PRODENG-2513-mod-updates branch November 12, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants