PRODENG- vendor updates 2024/01#410
Merged
james-nesbitt merged 1 commit intoFeb 7, 2024
Merged
Conversation
Collaborator
james-nesbitt
commented
Jan 26, 2024
- all go mod libraries updated
- go-playground/validator required two small changes
- k0sproject/rig update is quite large, so needs testing
dimitarbytes
approved these changes
Jan 26, 2024
Collaborator
Author
|
discovered some issues with winrm hosts, so I turned this into a draft PR: It looks like it is an issue with the windows installer, but I can't be sure. Without windows hosts we have no problem. |
Collaborator
|
Could be a bug in rig |
Collaborator
|
I'm not 100% sure if this is the problem: // InstallMCR install MCR on Windows.
func (c WindowsConfigurer) InstallMCR(h os.Host, scriptPath string, engineConfig common.MCRConfig) error {
pwd := c.Pwd(h)
base := path.Base(scriptPath)
installer := pwd + "\\" + base + ".ps1"
err := h.Upload(scriptPath, installer)I think rig expects |
Collaborator
|
Yep, I bumped into the same error, this fixed it for me: k0sproject/rig#165 |
Collaborator
|
It's now released as v0.17.5 |
- all go mod libraries updated - go-playground/validator required two small changes - k0sproject/rig update is quite large, so needs testing Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
Collaborator
Author
|
just pulled it in, and am finishing testing now. |
Collaborator
Author
|
latest force push is a rebase. |
Collaborator
Author
|
k0sproject/rig#165 did resolve the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.