PRODENG-2607 Fixed osHost OS + Arch interpretation for binary download#462
Merged
dimitarbytes merged 1 commit intoMirantis:masterfrom Apr 8, 2024
dimitarbytes:2607-fix-oshost
Merged
PRODENG-2607 Fixed osHost OS + Arch interpretation for binary download#462dimitarbytes merged 1 commit intoMirantis:masterfrom dimitarbytes:2607-fix-oshost
dimitarbytes merged 1 commit intoMirantis:masterfrom
dimitarbytes:2607-fix-oshost
Conversation
Signed-off-by: Dimitar Dimitrov <ddimitrov@mirantis.com>
Collaborator
|
Maybe this is a better place to start: https://github.com/Mirantis/mcc/blob/master/.goreleaser.release.yml#L29 I do like that cleanup on the unneeded transforms for windows and 64bit arch. |
james-nesbitt
approved these changes
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
launchpad-darwin-arm64tolaunchpad_darwin_amd64_1.5.6which caused breakage in osHost() function.https://mirantis.jira.com/browse/PRODENG-2607