PRODENG-2593 Functional tests for download-launchpad#463
Merged
james-nesbitt merged 2 commits intoMirantis:masterfrom Apr 10, 2024
dimitarbytes:2593-launchpad-download
Merged
PRODENG-2593 Functional tests for download-launchpad#463james-nesbitt merged 2 commits intoMirantis:masterfrom dimitarbytes:2593-launchpad-download
james-nesbitt merged 2 commits intoMirantis:masterfrom
dimitarbytes:2593-launchpad-download
Conversation
Signed-off-by: Dimitar Dimitrov <ddimitrov@mirantis.com>
Signed-off-by: Dimitar Dimitrov <ddimitrov@mirantis.com>
Collaborator
james-nesbitt
left a comment
james-nesbitt
left a comment
There was a problem hiding this comment.
The changes to test/integration/integration_test.go are not clear:
why the change to TestMKEClientConfig?
| if err != nil { | ||
| t.Fatalf("failed to remove file: %s", err) | ||
| } | ||
| }) |
Collaborator
There was a problem hiding this comment.
Is there an advantage to t.Cleanup over a simple defer ?
james-nesbitt
approved these changes
Apr 10, 2024
james-nesbitt
approved these changes
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
launchpad download-launchpadhttps://mirantis.jira.com/browse/PRODENG-2593