PRODENG-2595 docker sudo refactor#476
Merged
james-nesbitt merged 1 commit intoMirantis:masterfrom May 3, 2024
james-nesbitt:PRODENG-2595-docker-sudo-fix
Merged
PRODENG-2595 docker sudo refactor#476james-nesbitt merged 1 commit intoMirantis:masterfrom james-nesbitt:PRODENG-2595-docker-sudo-fix
james-nesbitt merged 1 commit intoMirantis:masterfrom
james-nesbitt:PRODENG-2595-docker-sudo-fix
Conversation
Collaborator
james-nesbitt
commented
May 3, 2024
james-nesbitt
commented
- no more generic sudo commands for the host (they were flaky)
- host has a sudodocker flag indicating that docker should be sudo
- same sudo exec plumbing is used, but now is used with the sudodocker flag
- no more generic sudo commands for the host (they were flaky) - host has a sudodocker flag indicating that docker should be sudo - same sudo exec plumbing is used, but now is used with the sudodocker flag Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
dimitarbytes
approved these changes
May 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.