Merged
Conversation
Collaborator
james-nesbitt
commented
Apr 4, 2025
- updated golangci-lint so new fixes show up
Collaborator
Author
|
Collaborator
Author
|
helm unit test will still fail, will fix that in another PR |
4b5c5e7 to
0ee44f4
Compare
Collaborator
Author
|
passed linging so I will merge it. |
- updated golangci-lint so new fixes show up Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
0ee44f4 to
9336497
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.