PRODENG-3066 docker images list regex refactor #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor the regex for interpreting command output as a list of images the regex was overly permissive probably due to golang string simplifications - added a test for the MKE387 output which was the trigger for the change Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
james-nesbitt
force-pushed
the
PRODENG-3066-docker-image-regex-refactor
branch
from
4a456bc to
b96fa80
Compare
Collaborator
Author
|
smoke test failure looks unrelated, but rather an issue with the TF init call. I will see if i can reproduce locally. |
Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
|
It's working on my test env. LGTM! �[37mDEBU�[0m [ssh] 3.141.196.124:22: executing `/usr/bin/docker run -i -v /var/run/docker.sock:/var/run/docker.sock --rm docker.io/mirantis/ucp:3.8.6 images --list --debug`
�[36mINFO�[0m MKE images: Skipping compatible engine version check for --force-engine-minimum
mirantis/ucp-agent:3.8.6
mirantis/ucp-alertmanager:3.8.6
mirantis/ucp-auth-store:3.8.6``` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.