PRODENG-3148 mcr version detect cleanup #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- go-version no longer throws a runtime error on invalid versions, so we
can drop our custom error catch version detection function
NOTE
What is this: we had issues when we first started analyzing the mcr version in
the configuration, as some invalid values would produce a runtime error. The
error came right out of hashicorps go-version library, so our only option
was to wrap the function and catch any runtime errors.
We also included a unit test which validated that a proper error was returned
on the invalid version value, to confirm in unit testing that the runtime
error was caught
Why isn't it needed anymore: I ran the go-version function recently without the
wrapper and found that the runtime exception no longer occurs, meaning that
our wrapper is no longer needed. The unit test now runs without exception
without the wrapper.
Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
Collaborator
Author
|
Here is the unit test which used to throw a runtime exception/error. |
nekwar
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
What is this: we had issues when we first started analyzing the mcr version in
the configuration, as some invalid values would produce a runtime error. The
error came right out of hashicorps go-version library, so our only option
was to wrap the function and catch any runtime errors.
We also included a unit test which validated that a proper error was returned
on the invalid version value, to confirm in unit testing that the runtime
error was caught
Why isn't it needed anymore: I ran the go-version function recently without the
wrapper and found that the runtime exception no longer occurs, meaning that
our wrapper is no longer needed. The unit test now runs without exception
without the wrapper.
Additionally, the go-version code now properly handles CalVer values,
which may have leading zeroes in values.