PRODENG-3100 Linux native MCR install#608
Merged
james-nesbitt merged 10 commits intomainfrom Mar 25, 2026
Merged
Conversation
Collaborator
james-nesbitt
commented
Jan 16, 2026
- drop install.sh for all linux configurers
e776423 to
d2e2a69
Compare
james-nesbitt
commented
Jan 16, 2026
d2e2a69 to
b39ecd3
Compare
- drop install.sh for all linux configurers
- linux configurer package based installers for el, sles and ubuntu
- move installer download into the configurers, and drop the download phase
- configurer download code has downloads globally.
- only windows configurer uses the installer downloader
- drop the installer download mke phase
TODO
- windows installs may fail for fips version, need to test
ALSO
- some more linting:
- interface{} -> any
Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
b39ecd3 to
01a9396
Compare
Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
- we don't use MCR version input, so we have to drop related
functionality:
- telemetry relies on channel
- we drop all pretending that we are verifying version (we didn't
do it properly before anyway)
- the very bad `EnsureMCRVersion` is replaced with `EnsureMCRRunning`
which doesn't totally behave the same (doesn't restart)
Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
d69b957 to
2a67096
Compare
- migrate 1.5 -> 1.6, which is actually kind of painful - update aws example Terraform that generates launchpad yaml - update smoke test to use new terraform, and also to test on RHEL9, Ubuntu22 and Sles15 - some fixes for the native configurers Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
2a67096 to
6b32aed
Compare
3346947 to
cc87604
Compare
Collaborator
Author
|
Currently, the smoke test fails on uninstall. I will look deeper. |
Collaborator
Author
|
I've been re-running the reset process and have not been able to duplicate the failed smoke test. I am preparing this for release. |
b6a04f3 to
3938022
Compare
- refactor configurer, reducing the interface - consolidate a number of methods into one - drop the base configurer installMCR method - configurers now implement InstallMCR() - some fixes to the core cmds to avoid stalling - reset no longer checks for version upgrade - test/example fixes - added better firewall rules to help avoid install failures Signed-off-by: James Nesbitt <jnesbitt@mirantis.com> Signed-off-by: James Nesbitt <james.r.nesbitt@gmail.com> Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
3938022 to
12e651a
Compare
corhere
reviewed
Mar 23, 2026
Co-authored-by: Cory Snider <corhere@gmail.com>
Co-authored-by: Cory Snider <corhere@gmail.com>
Co-authored-by: Cory Snider <corhere@gmail.com>
Co-authored-by: Cory Snider <corhere@gmail.com>
- simpler mke configurer validation test Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
corhere
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.