Conversation
|
|
Contributor
|
PTAL on codecliate issues. Rest LGTM. |
Contributor
Author
|
@jellonek thanks for the review! fixed. |
lukaszo
approved these changes
Jun 19, 2019
Contributor
lukaszo
left a comment
lukaszo
left a comment
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 1 approvals obtained
jellonek
reviewed
Jun 19, 2019
Contributor
jellonek
left a comment
jellonek
left a comment
There was a problem hiding this comment.
LGTM
Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status:
jellonek
reviewed
Jun 19, 2019
Contributor
jellonek
left a comment
jellonek
left a comment
There was a problem hiding this comment.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use
Virtletdeployed on GKE, but I cannot usevalidateorsshcommands because of:This PR will fix that issue.
This change is