fix: Use GetStableHashCode16 instead of truncation#4102
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4102 +/- ##
=======================================
Coverage 43.56% 43.56%
=======================================
Files 150 150
Lines 14626 14626
=======================================
Hits 6372 6372
Misses 8254 8254
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetStableHashCode16uses XOR folding instead of truncation to reduce hash collisions, but we weren't using it everywhere.Technical Justification
XOR folding preserves information from both halves of the 32-bit hash:
• Truncation example: 0x12345678 & 0xABCD5678 → both become 0x5678 ❌ Collision!
• XOR folding example:
• 0x12345678 → 0x1234 ^ 0x5678 = 0x444C
• 0xABCD5678 → 0xABCD ^ 0x5678 = 0xF9B5 ✅ Different results
This method is described in the official FNV documentation as the recommended approach for hash size reduction.