Skip to content

Fix .be TLD parsing; add google.be test fixture#1

Merged
Misiu merged 5 commits intomasterfrom
copilot/fix-whoisdomain-pl
Mar 25, 2026
Merged

Fix .be TLD parsing; add google.be test fixture#1
Misiu merged 5 commits intomasterfrom
copilot/fix-whoisdomain-pl

Conversation

Copy link

Copilot AI commented Mar 25, 2026

The .be TLD definition was broken: it extended "pl" (wrong base), had no explicit _server, and the registrar regex matched Company Name: which doesn't exist in .be WHOIS responses. The .pl definition also used private test domains.

Changes

.be TLD (ZZ["be"])

  • extend: "pl"extend: "com" — pl was an inappropriate base
  • Added _server: "whois.dns.be" — not inherited, must be explicit
  • Fixed registrar regex: Company Name:\n?(.+)Registrar:\s*\n\s+Name:\s*(.+) to match actual .be format
  • Added expiration_date: None, updated_date: None — these fields don't appear in .be WHOIS output
  • Set _test: "google.be"

.pl TLD (ZZ["pl"])

  • Removed private test domains jagusz.pl / omnivent.pl
  • Added testdata/wp.pl/input as replacement public test fixture
  • extend: "uk"extend: "com", added _server: "whois.dns.pl" and domain_name regex
  • Kept _test: "google.pl"

New test fixture

testdata/google.be/input — real .be WHOIS response covering domain name, status, creation date, registrar (Name: key), and bare-hostname nameservers.

Domain:     google.be
Status:     NOT AVAILABLE
Registered: Tue Dec 12 2000
Registrar:
    Name:   Markmonitor Inc.
Nameservers:
    ns3.google.com
    ns1.google.com
    ns2.google.com
    ns4.google.com

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Copilot AI changed the title [WIP] Fix whoisdomain for .pl domains to return valid results Fix .pl domain whois queries always returning None Mar 25, 2026
Copilot AI requested a review from Misiu March 25, 2026 08:24
Copilot AI changed the title Fix .pl domain whois queries always returning None Fix .pl whois: route queries to whois.dns.pl and parse Polish WHOIS format Mar 25, 2026
Copilot AI changed the title Fix .pl whois: route queries to whois.dns.pl and parse Polish WHOIS format Replace private .pl test domains with public ones (wp.pl, domena.pl) Mar 25, 2026
Copilot AI changed the title Replace private .pl test domains with public ones (wp.pl, domena.pl) Fix .be TLD parsing; add google.be test fixture Mar 25, 2026
@Misiu Misiu marked this pull request as ready for review March 25, 2026 08:46
@Misiu Misiu merged commit 928c6ff into master Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants