Add pylint to CI, Python version matrix, and fix requires-python#4
Draft
Add pylint to CI, Python version matrix, and fix requires-python#4
Conversation
Agent-Logs-Url: https://github.com/Misiu/WhoisDomain/sessions/a428e5ba-65f5-46c4-b0b7-e3a25613d9c4 Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix all errors to pass workflow checks
Remove empty Mar 27, 2026
if __name__ == "__main__" blocks to fix ruff CI failures
…thon Agent-Logs-Url: https://github.com/Misiu/WhoisDomain/sessions/c5dde6a2-962a-4e5f-a871-0b865b23036b Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com>
Copilot
AI
changed the title
Remove empty
Add pylint to CI, Python version matrix, and fix requires-python
Mar 27, 2026
if __name__ == "__main__" blocks to fix ruff CI failures
5 tasks
Misiu
added a commit
that referenced
this pull request
Mar 27, 2026
…#4 (#5) (mboot-github#44) * Add pylint to CI, Python version matrix, and fix requires-python Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI workflow was missing pylint (despite
.pylintrcbeing present), only tested against Python 3.12, and declared an incorrectrequires-pythonconstraint.Changes
lint.yml— lint job: Addedpylintinstall andpylint --rcfile=.pylintrc whoisdomain/step alongside the existing ruff and mypy checks.lint.yml— newtestjob: Matrix across Python3.10,3.11,3.12,3.13(fail-fast: false); each leg installs the package and runs a smoke test:python -c "import whoisdomain; print(whoisdomain.getVersion())"pyproject.toml: Changedrequires-python = ">3.6"→">=3.10"to matchruff.toml'starget-version = "py310"and the Makefile's explicit "tested on 3.10–3.14" note..pylintrc: Removed the obsoletesuggestion-modeoption, which newer pylint versions reject asE0015: Unrecognized option.⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.