Adding the FR version of Advanced Mapping in JOSM #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
similar to d88904e this will require some additional changes to:
i can help if needed, but not for probably several days. |
Contributor
Author
|
Noted! I'll look into it and let you know if I have any questions. Thanks |
Contributor
Author
|
@danbjoseph As per my comment, I changed the names of some of the functions in the gulpfile.js Let me know if that does not work. |
Member
|
i think this looks good. and yes, you're right that the function names needed an update based on evolving content of the files. |
danbjoseph
reviewed
Aug 24, 2022
| <div class="row contribute-options"> | ||
| <div class="columns" style="text-align: center"> | ||
| <a href="{{ site.baseurl }}/assets/downloads/JOSM_Advanced_Mapping_EN.pdf"> | ||
| <a href="{{ site.baseurl }}/assets/downloads/{{site.data[locale].checker.links.advancedJOSM_pdf:}}"> |
Member
There was a problem hiding this comment.
i didn't catch this before merging but the : at the end inside the }} might cause a problem
danbjoseph
reviewed
Aug 24, 2022
| guide: "JOSM Guide" | ||
| links: | ||
| guide: "Manuel de cartographie avancée avec JOSM" | ||
| advancedJOSM_pdf: "JOSM_Advanced_Mapping_EN.pdf" |
Member
There was a problem hiding this comment.
and i think this needs _FR swapped into the filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.