Fix search functionality error

[j4ys0n]

…format

The direction_select was using a list of dictionaries with 'label' and 'value' keys, which is Quasar's format but not supported directly by NiceGUI. This caused a ValueError: Invalid value: desc because NiceGUI wraps these options differently, making the value 'desc' not match any valid option.

Changed to NiceGUI's proper dictionary format where keys are values and values are labels: {'desc': 'Descending', 'asc': 'Ascending'}. This eliminates the need for emit-value and map-options props.

Fixes the search dialog failing to open with ValueError.

[Copilot]

Pull Request Overview

This PR simplifies the direction_select UI component in the HuggingFace search dialog by refactoring its options format and removing unnecessary Quasar props.

• Changed the direction select options from a list of dictionaries to a simpler dictionary format
• Removed the .props('emit-value map-options') call that is no longer needed with the dictionary format

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The dictionary keys and values are swapped compared to the typical NiceGUI pattern. With the new dictionary format {'desc': 'Descending', 'asc': 'Ascending'}, the keys ('desc', 'asc') are used as values and the dict values ('Descending', 'Ascending') are used as labels. When accessing self.direction_select.value on line 106, it will now correctly return the string keys ('desc' or 'asc'), which matches the expected behavior. However, this is the opposite pattern from the removed code where emit-value was needed. Consider verifying this works as expected with the rest of the codebase, particularly line 106 where direction_str = str(self.direction_select.value) expects 'desc' or 'asc' as values.

[j4ys0n]

Automated review 🤖

Summary of Changes
This PR fixes a ValueError in the search dialog by correcting the format of direction options passed to NiceGUI's ui.select. The previous implementation used Quasar-style dictionaries which weren't properly handled by NiceGUI, causing the 'desc' value to be unrecognized. The fix restructures the options into NiceGUI's expected key-value format and removes unnecessary props.

Key Changes & Positives

• 🟢 Correctly restructures direction_select options from Quasar format to NiceGUI's expected dictionary format
• 🟢 Removes redundant emit-value and map-options props that were causing conflicts
• 🟢 Simplifies the component configuration while maintaining functionality

Potential Issues & Recommendations

1. Issue / Risk: The change modifies the data structure for select options, which could affect other components or tests that depend on the old format
   Impact: May break existing code that expects Quasar-style options
   Recommendation: Verify all consumers of this component or related select components are updated to handle the new format
   Status: 🟡 Needs review

2. Issue / Risk: No explicit error handling for invalid direction values
   Impact: Could cause runtime issues if invalid values are passed
   Recommendation: Add validation or default handling for unexpected direction values
   Status: 🟡 Needs review

Language/Framework Checks

• Python: ✅ Proper NiceGUI component usage with correct option format
• NiceGUI: ✅ Correct dictionary format for select options, proper class application

Security & Privacy

• No security or privacy concerns introduced

Build/CI & Ops

• No build or deployment changes

Tests

• No test changes included; should verify that existing search dialog tests pass with the new format
• Consider adding tests for invalid direction values to ensure robustness

Approval Recommendation
Approve with caveats

• Verify all components using similar select options are updated to handle the new format
• Confirm existing tests still pass with the modified component
• Consider adding validation for direction values to prevent runtime errors