[Dto]: drop FluentValidation integration from CRUD/DTO generation#10
Merged
[Dto]: drop FluentValidation integration from CRUD/DTO generation#10
Conversation
The generator used to detect FluentValidation.AbstractValidator`1 in the
compilation and, when present, emit a FluentDtoValidator<T> bridge class
plus {RequestName}Create/UpdateBaseValidator scaffolds wired onto each
generated DTO. This dragged the external FluentValidation package into
every project that generated CRUD DTOs and had it referenced anywhere
transitively.
We no longer want that dependency. Removed:
- FluentDtoValidatorSource constant (the FluentValidation bridge base class)
- hasFluentValidation CompilationProvider gate
- RegisterSourceOutput that emitted FluentDtoValidator.g.cs
- GenerateFluentBaseValidator and all its call-sites
- hasFluent parameter plumbing through GenerateSource / EmitDeduplicatedNested
and every Combine() chain that fed it
- docs pages that described the FluentValidation bridge
Kept: IDtoValidator<T>, DtoValidationResult, and [Create/Update/CreateOrUpdate]
Validator / CreateValidator / UpdateValidator attribute properties — those
are generic and let users point at any custom validator implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generator used to detect FluentValidation.AbstractValidator`1 in the compilation and, when present, emit a FluentDtoValidator bridge class plus {RequestName}Create/UpdateBaseValidator scaffolds wired onto each generated DTO. This dragged the external FluentValidation package into every project that generated CRUD DTOs and had it referenced anywhere transitively.
We no longer want that dependency. Removed:
Kept: IDtoValidator, DtoValidationResult, and [Create/Update/CreateOrUpdate]
Validator / CreateValidator / UpdateValidator attribute properties — those
are generic and let users point at any custom validator implementation.