Merged
Conversation
eba8c8b to
ab137ff
Compare
ab137ff to
80e13bb
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds GeeTest captcha support as a third captcha provider option alongside the existing Google reCAPTCHA and hCAPTCHA implementations.
Key changes:
- Integrates GeeTest V4 captcha system with fallback logic
- Adds comprehensive timeout handling and error reporting for all captcha types
- Implements automatic captcha type selection based on server error descriptions
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| local.defaults.properties | Adds GEETEST_KEY configuration property |
| CaptchaView.kt | Implements GTCaptcha support with timeout handling and JS injection |
| GTCaptcha4Utils.kt | Utility class for parsing GeeTest captcha responses |
| VerificationRequest.kt | Adds GeeTest-specific fields to API request structure |
| captcha.html | Adds GTCaptcha initialization JavaScript functions |
| gt4.js | GeeTest V4 JavaScript library implementation |
| Multiple Fragment files | Updates captcha initialization to support type selection based on error descriptions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
app/src/main/java/one/mixin/android/ui/landing/GTCaptcha4Utils.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # app/src/main/java/one/mixin/android/ui/landing/SetupNameFragment.kt
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.