Skip to content

Feature/trading perpetual#6177

Merged
crossle merged 155 commits intomasterfrom
feature/trading_perpetual
Mar 24, 2026
Merged

Feature/trading perpetual#6177
crossle merged 155 commits intomasterfrom
feature/trading_perpetual

Conversation

@SeniorZhai
Copy link
Copy Markdown
Member

No description provided.

@SeniorZhai SeniorZhai force-pushed the feature/trading_perpetual branch from eb54b83 to 6a21c2e Compare March 20, 2026 15:10
@crossle
Copy link
Copy Markdown
Member

crossle commented Mar 20, 2026

@claude[agent] review

@Claude
Copy link
Copy Markdown
Contributor

Claude AI commented Mar 20, 2026

@crossle I've opened a new pull request, #6242, to work on those changes. Once the pull request is ready, I'll request review from you.

Claude AI and others added 3 commits March 21, 2026 21:45
* Initial plan

* Address code review feedback on perps feature

- Remove invalid android:orientation from RelativeLayout in XML
- Fix error_waiting_other_orders string to match semantic meaning
- Fix unqualified PageScaffold imports in AllPerpsMarketsFragment and TradePage
- Fix incorrect SQL predicate in getTotalUnrealizedPnl (was comparing state to boolean expression)
- Update PerpsMarketListAdapter to use displaySymbol instead of tokenSymbol for market list display
- Migrate PerpsMarketListAdapter to ListAdapter with DiffUtil for better performance

Co-authored-by: crossle <1675131+crossle@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MixinNetwork/android-app/sessions/cebbbbc8-dbf8-4107-b0c8-2514fffb2c9d

* fix package name

* fix typo

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: crossle <1675131+crossle@users.noreply.github.com>
Co-authored-by: Crossle Song <crosslesong@gmail.com>
@SeniorZhai SeniorZhai force-pushed the feature/trading_perpetual branch from e40e212 to bdfe44d Compare March 23, 2026 02:57
@SeniorZhai SeniorZhai force-pushed the feature/trading_perpetual branch from 6fd1eb4 to 31de79d Compare March 23, 2026 13:20
@crossle crossle merged commit 5ea58f3 into master Mar 24, 2026
3 checks passed
@crossle crossle deleted the feature/trading_perpetual branch March 24, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants