Merged
Conversation
SeniorZhai
force-pushed
the
ix/set-pin-error-handling
branch
from
9bfa204 to
23990e3
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the PIN setup “loading” UI by wiring TIP flow step updates from TipFlowInteractor into SetupPinViewModel and rendering more granular status/error messages in the Compose loading page. It also removes an unused ConversationRepository.create(...) wrapper in favor of the suspend API.
Changes:
- Add
tipStepLiveData toSetupPinViewModeland update it viaTipFlowInteractor.process(onStepChanged=...). - Update
SetPinLoadingPageto display step-specific progress/error messages and colors based onTipStep. - Remove the non-suspend
ConversationRepository.create(...)method.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/src/main/java/one/mixin/android/ui/landing/SetupPinViewModel.kt | Publishes TIP step changes (TipStep) alongside existing setup state for UI consumption. |
| app/src/main/java/one/mixin/android/ui/landing/components/SetPinLoadingPage.kt | Maps TipStep to user-facing status text/color during loading and failure states. |
| app/src/main/java/one/mixin/android/repository/ConversationRepository.kt | Cleans up a removed/unused non-suspend create wrapper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+86
to
+92
| is RetryConnect -> buildString { | ||
| if (step.reason.isNotBlank()) { | ||
| append(step.reason) | ||
| append('\n') | ||
| } | ||
| append(stringResource(R.string.Connect_to_TIP_network_failed)) | ||
| } |
| val errorMessage by viewModel.errorMessage.observeAsState("") | ||
| val context = LocalContext.current | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.