Conversation
Agent-Logs-Url: https://github.com/MixinNetwork/android-app/sessions/819bda26-8c30-47bf-abe2-5672618e8713 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: SeniorZhai <5416585+SeniorZhai@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR focuses on improving Gradle/Android build performance via build-tooling configuration updates and minor build script cleanup.
Changes:
- Tunes Gradle/Kotlin daemon JVM args and enables Gradle configuration cache, VFS watching, and incremental build-related flags.
- Updates repository declarations in the root
build.gradleto consistent property-assignment syntax and removes a duplicate repository entry. - Adjusts
app/build.gradleAndroid DSL to property-assignment style and attempts to disable Firebase Performance instrumentation fordebug.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
gradle.properties |
Enables configuration cache/VFS watch and incremental flags; adjusts daemon JVM settings. |
build.gradle |
Normalizes maven { url = ... } syntax and cleans up repository list. |
app/build.gradle |
Converts several Android DSL fields to assignment syntax; adds Firebase Performance config in debug; removes a Room KSP arg. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| jniDebuggable false | ||
| signingConfig = signingConfigs.debug | ||
| jniDebuggable = false | ||
| FirebasePerformance { |
There was a problem hiding this comment.
FirebasePerformance { ... } is likely an invalid DSL block and will fail Gradle configuration (or be ignored). The Firebase Performance plugin exposes the firebasePerformance extension (lowercase) for configuring instrumentation; please use the correct extension name (and verify whether it belongs at the module level or inside the debug buildType).
| FirebasePerformance { | |
| firebasePerformance { |
No description provided.