Skip to content

reduce ReadSimVars() count to improve performance #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cpuwolf wants to merge 2 commits into from
Closed

reduce ReadSimVars() count to improve performance #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5b14d1
reduce ReadSimVars() count to improve performance
cpuwolf May 2, 2022
fc0cbb5
too slow for feedback data
cpuwolf May 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions src/Sources/Code/Module.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include <SimConnect.h>
#include <MSFS\Legacy\gauges.h>
#include <vector>
#include <list>
#include <string>
#include <sstream>
#include <iostream>
Expand Down Expand Up @@ -53,11 +54,14 @@ struct Client {
SIMCONNECT_CLIENT_DATA_ID DataAreaIDCommand;
SIMCONNECT_CLIENT_DATA_DEFINITION_ID DataDefinitionIDStringResponse;
SIMCONNECT_CLIENT_DATA_DEFINITION_ID DataDefinitionIDStringCommand;
std::vector<SimVar> SimVars;
std::list<SimVar> SimVars;
SIMCONNECT_CLIENT_DATA_DEFINITION_ID DataDefinitionIdSimVarsStart;
// This is an optimization to be able to re-use already defined data definition IDs & request IDs
// after resetting registered SimVars
uint16_t MaxClientDataDefinition = 0;
// Runtime Rolling CLient Data reading Index
std::list<SimVar>::iterator RollingClientDataReadIndex;

};

// The list of currently registered clients
Expand Down Expand Up @@ -230,7 +234,7 @@ void WriteSimVar(SimVar& simVar, Client* client) {

// Register a single SimVar and send the current value to SimConnect Clients
void RegisterSimVar(const std::string code, Client* client) {
std::vector<SimVar>* SimVars = &(client->SimVars);
std::list<SimVar>* SimVars = &(client->SimVars);
SimVar var1;
var1.Name = code;
var1.ID = SimVars->size() + client->DataDefinitionIdSimVarsStart;
Expand All @@ -250,6 +254,7 @@ void RegisterSimVar(const std::string code, Client* client) {
);

client->MaxClientDataDefinition = SimVars->size();
client->RollingClientDataReadIndex = SimVars->begin();
}
#if _DEBUG
fprintf(stderr, "MobiFlight[%s]: RegisterSimVar SimVars Size: %d\n", client->Name.c_str(), SimVars->size());
Expand All @@ -272,6 +277,7 @@ void RegisterSimVar(const std::string code, Client* client) {
void ClearSimVars(Client* client) {
client->SimVars.clear();
fprintf(stderr, "MobiFlight: Cleared SimVar tracking.");
client->RollingClientDataReadIndex = client->SimVars.begin();
}

// Read a single SimVar and send the current value to SimConnect Clients
Expand All @@ -292,9 +298,15 @@ void ReadSimVar(SimVar &simVar, Client* client) {
// Read all dynamically registered SimVars
void ReadSimVars() {
for (auto& client : RegisteredClients) {
std::vector<SimVar>* SimVars = &(client->SimVars);
for (auto& value : *SimVars) {
ReadSimVar(value, client);
std::list<SimVar>* SimVars = &(client->SimVars);
//circular list, Max 12 SimVars at once
for (int i=0; i < 12; ++i) {
std:advance(client->RollingClientDataReadIndex, 1);
if(client->RollingClientDataReadIndex == SimVars->end()){
client->RollingClientDataReadIndex = SimVars->begin();
}

ReadSimVar(*(client->RollingClientDataReadIndex), client);
}
}
}
Expand Down Expand Up @@ -378,7 +390,7 @@ Client* RegisterNewClient(const std::string clientName) {
newClient->DataAreaNameCommand = newClient->Name + std::string(CLIENT_DATA_NAME_POSTFIX_COMMAND);
newClient->DataDefinitionIDStringResponse = 2 * newClient->ID; // 500 Clients possible until offset 1000 is reached
newClient->DataDefinitionIDStringCommand = newClient->DataDefinitionIDStringResponse + 1;
newClient->SimVars = std::vector<SimVar>();
newClient->SimVars = std::list<SimVar>();
newClient->DataDefinitionIdSimVarsStart = SimVarOffset + (newClient->ID * ClientDataDefinitionIdSimVarsRange);

RegisteredClients.push_back(newClient);
Expand Down