Adds Bazel Build Support#86
Merged
keith merged 5 commits intoMobileNativeFoundation:masterfrom May 3, 2021
Merged
Conversation
Adds the ability to build Kronos via Bazel, also adds a Github Action to test the Bazel Builds Signed-off-by: Maxwell Elliott <maxwell.elliott@gotinder.com>
tinder-maxwellelliott
force-pushed
the
maxwelle/bazel_support
branch
7 times, most recently
from
bf6f8db to
ed6a4e1
Compare
keith
reviewed
Apr 22, 2021
tinder-maxwellelliott
force-pushed
the
maxwelle/bazel_support
branch
2 times, most recently
from
7d493f7 to
f19a590
Compare
tinder-maxwellelliott
force-pushed
the
maxwelle/bazel_support
branch
from
f19a590 to
8aba68f
Compare
keith
previously approved these changes
Apr 23, 2021
tinder-maxwellelliott
force-pushed
the
maxwelle/bazel_support
branch
from
8aba68f to
36aa4bc
Compare
Member
|
looks like a python version error in the iOS tests, might be a bug in the rules that breaks on 2.7, might need to define a python 3 only toolchain here |
tinder-maxwellelliott
force-pushed
the
maxwelle/bazel_support
branch
2 times, most recently
from
4f61df6 to
1d82a68
Compare
Member
|
looks like it's still failing on something related to that, i don't think you should have to install a new python tho since Xcode 12 + catalina have that at this point (assuming CI versions are updated) |
tinder-maxwellelliott
force-pushed
the
maxwelle/bazel_support
branch
from
1d82a68 to
4e08438
Compare
Member
|
Looks like it's still falling |
Signed-off-by: Maxwell Elliott <maxwell.elliott@gotinder.com>
tinder-maxwellelliott
force-pushed
the
maxwelle/bazel_support
branch
from
4e08438 to
86f5b2a
Compare
Contributor
Author
Can I get another run of the GH action? |
tinder-maxwellelliott
force-pushed
the
maxwelle/bazel_support
branch
2 times, most recently
from
078107d to
b65e62f
Compare
Member
|
you must be hitting google/xctestrunner#29 |
tinder-maxwellelliott
force-pushed
the
maxwelle/bazel_support
branch
3 times, most recently
from
069e08a to
e672b5f
Compare
Signed-off-by: Maxwell Elliott <maxwell.elliott@gotinder.com>
tinder-maxwellelliott
force-pushed
the
maxwelle/bazel_support
branch
from
e672b5f to
cf50a82
Compare
keith
previously approved these changes
Apr 29, 2021
Signed-off-by: Maxwell Elliott <maxwell.elliott@gotinder.com>
tinder-maxwellelliott
force-pushed
the
maxwelle/bazel_support
branch
from
f31382e to
9621e46
Compare
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to build Kronos via Bazel, also adds a Github Action
to test the Bazel Builds