[BUG] Crash in Store 4.0 with Kotlin 1.5.0-RC

[SteinerOk]

Describe the bug
Application crash after update Kotlin from 1.4.32 to 1.5.0-RC, no other changes in code.

Catch Exception:

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: ru.superapplication.android.app.debug, PID: 18674
    java.lang.NoSuchMethodError: No static method getHours(I)D in class Lkotlin/time/DurationKt; or its super classes (declaration of 'kotlin.time.DurationKt' appears in /data/app/~~l_eMNOPYSnv8XUlDP7ycgA==/ru.superapplication.android.app.debug-ziiU-phO368T6tA7R1CseQ==/base.apk!classes33.dex)
        at com.dropbox.android.external.store4.StoreDefaults.<clinit>(StoreDefaults.kt:15)
        at com.dropbox.android.external.store4.RealStoreBuilder.<init>(StoreBuilder.kt:91)
        at com.dropbox.android.external.store4.StoreBuilder$Companion.from(StoreBuilder.kt:76)

[digitalbuddha]

Thanks will take a look tomorrow

[Uorlak]

Have the same issue, waiting for fix.

[SteinerOk]

@digitalbuddha I think this crash related with https://blog.jetbrains.com/kotlin/2021/04/kotlin-1-5-0-rc-released/#duration-api-changes

[digitalbuddha]

Yup makes sense. I will have a fix up this week. I was contemplating dropping duration as dependency all together

…

On Sun, Apr 18, 2021, 3:49 AM Ihor Kushnirenko ***@***.***> wrote: @digitalbuddha <https://github.com/digitalbuddha> I think this crash related with https://blog.jetbrains.com/kotlin/2021/04/kotlin-1-5-0-rc-released/#duration-api-changes — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#263 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCRPXH65PQYU7AMRAQDKULTJKFIBANCNFSM424HRFFA> .

[digitalbuddha]

Hi friends, we won't be able to release until next week. We are working on fixing the codecov vulnerability prior to triggering any more releases.

[bishiboosh]

@digitalbuddha with the release of 1.5.0 today, do you think you'd be able to release a version so we can migrate safely ?

[digitalbuddha]

https://search.maven.org/artifact/com.dropbox.mobile.store/store4/4.0.1/jar

[bishiboosh]

I still seem to have the same issue, any idea why ? I have this crash :

java.lang.NoSuchMethodError: No static method toDuration(ILjava/util/concurrent/TimeUnit;)D in class Lkotlin/time/DurationKt; or its super classes (declaration of 'kotlin.time.DurationKt' appears in /data/app/com.enki.Enki750g-cJ-mwUBphcam5o5DgtJjRg==/base.apk!classes19.dex)
        at com.dropbox.android.external.store4.StoreDefaults.<clinit>(StoreDefaults.kt:16)
        at com.dropbox.android.external.store4.RealStoreBuilder.<init>(StoreBuilder.kt:91)
        at com.dropbox.android.external.store4.StoreBuilder$Companion.from(StoreBuilder.kt:76)

[SteinerOk]

@digitalbuddha I have the same issue with Kotlin 1.5.0 like described @bishiboosh.
I think it related with Duration-type variable, in Kotlin 1.4 rawValue after compile is Double, but in 1.5 it is Long.
Store compiled with 1.4.10 and when try to use Store with Kotlin 1.5 we have crash (type incompatible).
My opinion, the 2 way to solve this problem:

1. compile Store with Kotlin 1.5, but we will have crash when use Store with Kotlin 1.4
2. remove usage Duration-type.

[bishiboosh]

@digitalbuddha I think removing Duration completely from the lib would be too much of an API change, I'd go with compiling Store with Kotlin 1.5 (and making it a breaking change like you first thought in #265)